feat: while jobset-wait retry on hydra failures #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While waiting for a jobset to complete, sometimes network requests can fail for many reasons. In these cases, the CLI will retry for 5 times in one minute, instead of just failing.
414owen
reviewed
Oct 2, 2023
|
Oops, I just saw the value of |
|
I see your points, it would be better to have those parameters configured from outside, but given that we already have the sleep value hard-coded I tried to set reasonable defaults, and keep the MR small. I think we can tackle the point of making this command more configurable and still keep these defaults. Would also be interesting to have dynamic seeps depending on the state of the jobset. Given how much jobset-wait does, it could make sense to just manage the sleeps automatically instead of having fixed parameters from the user. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While waiting for a jobset to complete, sometimes network requests can fail for many reasons. In these cases, the CLI will retry for 5 times in one minute, instead of just failing.