-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't re-instantiate nixpkgs in flake and module #67
Conversation
Hello, So, you need to
|
This will allow the overlay to still easily be used by those on systems not directly supported by the Flake, or those who just prefer to use them over pure attributes
and stop using the now removed `lib.mdDoc` • Updated input 'nixpkgs': 'path:/nix/store/f3rv70nrmkfya581f1j2z9a6yx0b83np-source?lastModified=1717281328&narHash=sha256-evZPzpf59oNcDUXxh2GHcxHkTEG4fjae2ytWP85jXRo%3D&rev=b3b2b28c1daa04fe2ae47c21bb76fd226eac4ca1' (2024-06-01) → 'github:NixOS/nixpkgs/fecfeb86328381268e29e998ddd3ebc70bbd7f7c?narHash=sha256-rvyfF49e/k6vkrRTV4ILrWd92W%2BnmBDfRYZgctOyolQ%3D' (2025-02-03)
858f27f
to
412c3e4
Compare
Done! I've updated the Nixpkgs revision as well, since it seems it was still on the now EOL 24.05 branch. |
Thank you! |
hm, looks like i merged it a bit too quickly: it no longer evaluates on my machines:
No time ATM to fix this. |
@@ -1,4 +1,4 @@ | |||
overlay: { config, pkgs, lib, ... }: | |||
self: { config, pkgs, lib, ... }: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this line is the culprit
self:
should be { self }:
This is expensive on evaluation, but can be easily avoided here as we aren't using unfree packages or special configurations
See https://zimbatm.com/notes/1000-instances-of-nixpkgs
The only systems this will affect are those not listed here, as the overlay will no longer be automatically applied and an assertion will be triggered. They will need to add
nixpkgs.overlays = [ comin.overlays.default ]
to their configuration; users on other systems will have overlayed packages used by default as well