refactor: remove nested modifier and unused multiline prop from unordered list mixins and stories#3113
refactor: remove nested modifier and unused multiline prop from unordered list mixins and stories#3113pixelgitter wants to merge 6 commits intomainfrom
Conversation
…st mixins and stories
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Ik heb main even naar je branch getrokken om de axios security issue op te lossen; die fix stond al in de main 👍 |
| export const CenterMultilineNested: Story = { | ||
| args: { | ||
| center: true, | ||
| multiline: true, |
There was a problem hiding this comment.
Did you remove this on purpose? Since the story id and story name still imply 'multiline'
| export const NarrowContainerCenterLongText: Story = { | ||
| args: { | ||
| center: true, | ||
| multiline: true, |
There was a problem hiding this comment.
Did you remove this on purpose? Since the story name still implies 'multiline'
There was a problem hiding this comment.
Dit moet denk ik wel teruggezet worden inderdaad
There was a problem hiding this comment.
Voor zover ik heb gezien werd er niks gedaan met de multiline argument. Als een zin lang is, gaat deze automatisch op multiline. Om die reden heb ik deze verwijderd.
|
Ik heb nu ook de token verwijderd :D Zou je zodra je PR is gemerged (of anytime eerder is ook al prima), in het designer kanaal kunnen vragen of iemand in Utrecht het token gebruik ook wilt verwijderen uit de Figma? |
|
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@utrecht/unordered-list-css": patch | |||
There was a problem hiding this comment.
| "@utrecht/unordered-list-css": patch | |
| "@utrecht/unordered-list-css": major |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3113 +/- ##
=======================================
Coverage 90.57% 90.57%
=======================================
Files 201 201
Lines 1751 1751
Branches 390 389 -1
=======================================
Hits 1586 1586
Misses 157 157
Partials 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| export const NarrowContainerCenterLongText: Story = { | ||
| args: { | ||
| center: true, | ||
| multiline: true, |
There was a problem hiding this comment.
Dit moet denk ik wel teruggezet worden inderdaad
| "@nrwl/cli": "15.9.7", | ||
| "@nrwl/nx-cloud": "15.3.5", | ||
| "@nrwl/cli": "15.9.3", | ||
| "@nrwl/nx-cloud": "19.1.3", |
There was a problem hiding this comment.
Waarom past deze PR dependencies aan, is dat de bedoeling?
If anything, denk ik dat nx verwijderd kan worden
3 participants
No description provided.