Extract VegaVisualization to separate package#3102
Draft
Conversation
…kage.json This should have been done before, and gives errors now that React is upgraded
Also add these dependencies to storybook-react. It previously depended on having a transitive dependency on these packages through a denhaag import (which imported utrecht again), but it needs to be explicit now otherwise you'll still get the old version.
…ga upgrade `VegaVisualization` now has an `options` prop which is passed into the underlying `VegaEmbed` component. The `actions` prop, which can also be controlled through `options`, has been deprecated.
Gatsby supports React 19 from 5.16.0 onwards. It is only used in BreadcrumbNav.test.tsx, which breaks on older versions of Gatsby.
This was done because this otherwise requires ts-node to be added as a dependency to run the tests
Needs @testing-library/react@16.1.0 for React 19 support. Since 16.0.0 introduced a breaking change where @testing-library/dom is now a peerDependency, this was added as a devDependency where it was missing. Mosts tests also failed because react-dom was not available, and this was also added as a devDependency.
As a tradeoff, the :only-child is removed because there are now two <body>s.
Since React 19 forbids rendering `<html>` as a child of anything, testing it is impossible using `render()`.
Components seem to be migrated. This cleans up about 50 transitive dependencies.
Fixes a build error on Vercel. Does not affect runtime behavior.
@storybook/blocks did not get a v9
Since this name is not exposed, it should not have any side effects.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
richadr
force-pushed
the
feature/vega-visualization-react
branch
from
07c9590 to
69bd976
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.