fix: add flex column layout to alert and spotlight for row-gap support#3078
Merged
fix: add flex column layout to alert and spotlight for row-gap support#3078
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3078 +/- ##
=======================================
Coverage 90.63% 90.63%
=======================================
Files 201 201
Lines 1751 1751
Branches 383 382 -1
=======================================
Hits 1587 1587
- Misses 156 158 +2
+ Partials 8 6 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
bddjong
reviewed
Apr 13, 2026
Robbert
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR
Add flex column layout to Alert and Spotlight so
row-gapcan be used.Note: the
row-gaptokens are now functional but have no default value. Users of these components can opt in by setting the token to their desired value in their theme.Related issue
nl-design-system/mijn-services#346