Fix a bug in ActionCards showing the wrong player ids.

GitOrigin-RevId: c496e2dfa0fb41f09b0b5d7ae55ba4c86845989c
nkzw-tech · Aug 5, 2024 · 3754ea4 · 3754ea4
1 parent fe542eb
commit 3754ea4
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/hera/editor/lib/ActionCard.tsx b/hera/editor/lib/ActionCard.tsx
@@ -11,6 +11,7 @@ import {
 import {
   DynamicPlayerIDs,
   encodeDynamicPlayerID,
+  isDynamicPlayerID,
   PlayerID,
   resolveDynamicPlayerID,
 } from '@deities/athena/map/Player.tsx';
@@ -145,7 +146,7 @@ export default memo(function ActionCard({
     const portrait = unit?.sprite.portrait;
     const player = hasCurrentPlayer
       ? resolveDynamicPlayerID(map, action.player, currentPlayer)
-      : 0;
+      : action.player;
     const message =
       formatText && factionNames && map && userDisplayName
         ? formatCharacterText(
@@ -156,7 +157,7 @@ export default memo(function ActionCard({
               : 'name',
             map,
             userDisplayName,
-            player,
+            isDynamicPlayerID(player) ? 0 : player,
             factionNames,
           )
         : action.message;