Skip to content

Do not use relative urls - #24

Merged
njkevlani merged 1 commit into
mainfrom
relative-urls
Sep 6, 2026
Merged

njkevlani merged 1 commit into
mainfrom
relative-urls

Conversation

@njkevlani

@njkevlani njkevlani commented Sep 6, 2026 •

Copy link
Copy Markdown
Owner

This was causing issues at some places. for example, non-root unknow pages (like https://njkevlani.dev/kb/any) were not able to resolve

Summary by CodeRabbit

  • Improvements
    • Site links now use absolute URLs, improving navigation and sharing across pages.
    • Resume pages now load their styling directly within the page for more reliable display.
    • Resume icons and other visual assets now use updated paths to ensure they render correctly across supported page locations.

This was causing issues at some places. for example, non-root unknow
pages (like https://njkevlani.dev/kb/any) were not able to resolve
@njkevlani
njkevlani merged commit e362d0b into main Sep 6, 2026
3 of 4 checks passed
@njkevlani
njkevlani deleted the relative-urls branch September 6, 2026 12:40
@coderabbitai

coderabbitai Bot commented Sep 6, 2026 •

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 169bac0d-958e-485e-94ec-92cdb58db492

📥 Commits

Reviewing files that changed from the base of the PR and between 981a8ca and 0472365.

📒 Files selected for processing (2)
  • hugo.toml
  • layouts/resume/single.html

📝 Walkthrough

Walkthrough

The site now generates absolute URLs. The resume template inlines its stylesheet and uses relative paths for location, link, score, and calendar icons.

Changes

Resume asset URL handling

Layer / File(s) Summary
Site URL configuration
hugo.toml
Removes relativeURLs = true, so Hugo generates absolute URLs.
Resume template assets
layouts/resume/single.html
Inlines the minified stylesheet and changes icon paths to relative paths.

Estimated code review effort: 2 (Simple) | ~10 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch relative-urls

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant