Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the build issue of undefined import self::consts on the loongarch64 #2568

Draft
wants to merge 1 commit into
base: r0.26
Choose a base branch
from

Conversation

DWwanghao
Copy link

What does this PR do

Fix failed to build for target loongarch64(similar to MIPS) with this error:

error[E0432]: unresolved import `self::consts`
  --> /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/nix-0.26.4/src/sys/ioctl/linux.rs:60:15
   |
60 | pub use self::consts::*;
   |               ^^^^^^ could not find `consts` in `self`

Checklist:

  • I have read CONTRIBUTING.md
  • I have written necessary tests and rustdoc comments
  • A change log has been added if this PR modifies nix's API

@DWwanghao DWwanghao force-pushed the fix-loongarch64-build branch from 5f89349 to 26cddd7 Compare December 20, 2024 07:35
Comment on lines +6 to +12
## [0.26.5] - 2024-12-20

### Fixed

- Fixed the build issue of undefined import self::consts on the loongarch64.
([#2568](https://github.com/nix-rust/nix/pull/2568))

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the changelog entry there: https://github.com/nix-rust/nix/tree/master/changelog

@SteveLauC
Copy link
Member

SteveLauC commented Dec 20, 2024

CI errors are not related to this PR

You are targeting the wrong branch, please file PRs against the master branch

@DWwanghao DWwanghao marked this pull request as draft December 25, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants