treewide: generate JSON instead of Nix #3832
Merged
+3,209
−4,296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Get file part from filepath and remove hash prefix | ||
| output_name=$(basename "$1" | cut -d "-" -f "2-") | ||
| basename "$1" ".json" | ||
| prettier "$1" > "$generated_dir/$output_name" |
There was a problem hiding this comment.
Aside: directly calling prettier in the update-script probably isn't the best design. Really, we should be using our treefmt configuration, so that we also get any settings (etc). But doing that without having to evaluate the rest of nixvim's flake may be non-trivial.
There was a problem hiding this comment.
I agree but out of scope for this PR. Though in practice our treefmt prettier is the same as this one for JSON files but of course this would help keep it in sync in the future.
Signed-off-by: saygo-png <[email protected]>
MattSturgeon
approved these changes
Oct 19, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sounds like buildbot is rebooting |
Yes, sorry. I'll re-queue this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3682 (comment)
It also cleans up the generate script a bit so we no longer have to repeat the name and the files always have the .json extension even in the nix derivation.
Didn't touch the maintainers script because I can't nor want to read Python.