treewide: fix nvd diffs and internal cleanup #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also CC @viperML because I'd like to mark this as the last PR for 4.1.0, it gets the known regressions out of the way and brings the new Darwin activation stuff into a release, which we'll need to hurry up with. |
NotAShelf
changed the title
|
Diff is working for me on darwin on this branch |
khaneliman
reviewed
May 22, 2025
|
I don't know if we are turning the codebase into some spaguetti, but the priority is to fix the diffs. |
viperML
approved these changes
May 22, 2025
I'll do some actual cleanup after 4.1.0, just interested in getting 4.1.0 out of the way before sit down for a potentially large refactor. #281 is still a priority, but it'll take me a little while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This'll create some merge conflicts, but I'd like to get this fixed before I take an extended break. Fixes nvd diffs and supresses a redundant argument that would occur after #208. Also improves debug logging for references that we need to keep track of. Should help track down issues such as this one easier in the future.
CC @khaneliman for Darwin testing, seems to be working as intended on NixOS- testing for Home Manager would also be great.