zsh: adjust initContent priorities #6676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaneliman
commented
Mar 21, 2025
| (lib.mkIf (cfg.initExtraFirst != "") (mkOrder 550 cfg.initExtraFirst)) | ||
| (lib.mkIf (cfg.initExtraFirst != "") (lib.mkBefore cfg.initExtraFirst)) |
There was a problem hiding this comment.
Wasn't sure if we wanted an easy migration of prio here so it's just using the mkBefore prio instead of an arbitrary number.
There was a problem hiding this comment.
I think it's fine. We should get rid of it anyway
khaneliman
commented
Mar 21, 2025
| (lib.mkIf (cfg.initExtra != "") (mkOrder 1200 cfg.initExtra)) | ||
| (lib.mkIf (cfg.initExtra != "") cfg.initExtra) |
There was a problem hiding this comment.
Removing custom prio here allows migration to be easier for initExtra to initContent
teto
approved these changes
Mar 21, 2025
To support easier migration of deprecating old zsh options. We can adjust the internal priorities to fit within the `mkBefore` (500) and default (1000). Makes it easier for `initExtraFirst` migrationg to `mkBefore` and `initExtra` to default prio.
6 tasks
ttrssreal
pushed a commit
to ttrssreal/home-manager
that referenced
this pull request
Mar 22, 2025
To support easier migration of deprecating old zsh options. We can adjust the internal priorities to fit within the `mkBefore` (500) and default (1000). Makes it easier for `initExtraFirst` migrationg to `mkBefore` and `initExtra` to default prio.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support easier migration of deprecating old zsh options. We can adjust the internal priorities to fit within the
mkBefore(500) and default (1000). Makes it easier forinitExtraFirstmigrationg tomkBeforeandinitExtrato default prio.Predecessor to #6664
We can iron out the priorities more, just wanted to quickly whip something up to get a discussion going.
Description
Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.allor
nix build --reference-lock-file flake.lock ./tests#test-allusing Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC