refactor(iam): consolidate access catalog route lookup into required_permission - #63
Merged
Merged
Conversation
…ing logic - Merged `source.rs` into `mod.rs` to streamline access catalog management. - Updated `AccessNode` and `AccessBinding` structures to enhance clarity and maintainability. - Refactored loading logic in `AccessCatalog` to directly query the database for nodes and bindings. - Adjusted permission handling to use normalized method and path parameters for consistency. - Removed redundant code and improved test cases to reflect changes in the access catalog structure.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolve→permission_for_menu) withrequired_permission, so request admission resolves the concrete Permission in one step.AccessCatalogas the small boundary overMenuIndexandRouteIndex; remove the low-valuesource.rsseam, tighten internal visibility, and stop loading the unused menu title.AccessService::evaluate, keep binding normalization at index construction, and document the lookup precondition.Verification
cargo fmt --all --checkcargo test -p iam --lockedcargo test --workspace --lockedcd apps/desktop && pnpm testcd apps/desktop && pnpm build