Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(netlify-builder): add deprecated warning #2972

Merged
merged 3 commits into from
Jan 7, 2025
Merged

docs(netlify-builder): add deprecated warning #2972

merged 3 commits into from
Jan 7, 2025

Conversation

gioboa
Copy link
Contributor

@gioboa gioboa commented Jan 7, 2025

🔗 Linked issue

Fixes #2946

image

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0
Copy link
Member

pi0 commented Jan 7, 2025

Do you mind to rebase your PR to v2 branch with removal of docs and addition of warning? 🙏🏼

@gioboa
Copy link
Contributor Author

gioboa commented Jan 7, 2025 •
edited
Loading

Do you mind to rebase your PR to v2 branch with removal of docs and addition of warning? 🙏🏼

Yep, I'll do it

---- UPDATE ----

✅ Done

@gioboa gioboa changed the base branch from main to v2 January 7, 2025 13:50
@gioboa gioboa requested a review from pi0 as a code owner January 7, 2025 13:50
@gioboa gioboa force-pushed the chore/remove_netlify_builder branch from e3b1d5b to 7164114 Compare January 7, 2025 13:54
serhalp
serhalp reviewed Jan 7, 2025
View reviewed changes
Copy link
Contributor

@serhalp serhalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

docs/2.deploy/20.providers/netlify.md Outdated Show resolved Hide resolved
@gioboa
Copy link
Contributor Author

gioboa commented Jan 7, 2025

Nice thanks

@gioboa gioboa requested a review from serhalp January 7, 2025 18:06
@pi0 pi0 changed the title chore: remove netlify builder docs(netlify-builder): add deprecated warning Jan 7, 2025
pi0
pi0 approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thnx!

@pi0 pi0 merged commit c3ee670 into nitrojs:v2 Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

@serhalp serhalp serhalp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

netlify_builder preset not working as expected (Netlify returning 405)
3 participants
@gioboa @pi0 @serhalp