fix(cli): align generate types UX with other generate flows#48
Open
sharma2464 wants to merge 1 commit into
Open
fix(cli): align generate types UX with other generate flows#48sharma2464 wants to merge 1 commit into
sharma2464 wants to merge 1 commit into
Conversation
generate types skipped showFooter() and analytics tracking that every other generate path (and init/dev/start) does on completion, leaving output visually inconsistent and untracked. Fixes nitrocloudofficial#14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generate typesskippedshowFooter()and analytics tracking (trackEvent/shutdownAnalytics) that every othergeneratepath already does on success/failuregenerate()dispatch — gap was purely the footer/tracking at the end ofgenerate-types.tsTest plan
npx tsc --noEmitcleannpm run buildsucceedsgenerate typeswith no*.tools.tsfiles — fails gracefully, no footer (matches other failure paths)generate typeswith a sample*.tools.tsfile — success path now ends with the footer block matching other generate commandsFixes #14
🤖 Generated with Claude Code