fix(cli): ASCII fallback for emoji/box-drawing when NO_COLOR is set#45
Open
sharma2464 wants to merge 2 commits into
Open
fix(cli): ASCII fallback for emoji/box-drawing when NO_COLOR is set#45sharma2464 wants to merge 2 commits into
sharma2464 wants to merge 2 commits into
Conversation
Terminals without unicode/emoji support render garbled CLI output. Add icons/BOX char maps in branding.ts gated on NO_COLOR env var, wire through dev/init/start commands. Fixes nitrocloudofficial#25
ora's succeed/fail/info/warn always prepend their own unicode symbol regardless of NO_COLOR, so prefixing icons.ok etc as text produced duplicate symbols (e.g. "✔ [ok] done"). Use stopAndPersist with an explicit symbol instead so only one symbol renders, ASCII or unicode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NO_COLORenv var is setbranding.ts(icons, box chars, banner) and intodev.ts,init.ts,start.tsTest plan
tsc --noEmitcleannpm run buildsucceedsNO_COLOR=1, confirmed icons/banners/boxes switch to plain ASCII and stay alignedFixes #25
🤖 Generated with Claude Code