Skip to content

Conversation

@heydoyouknowme0
Copy link
Contributor

No description provided.

@heydoyouknowme0 heydoyouknowme0 changed the title feat: flexible faculty details feat: faculty integration Apr 15, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 15 out of 16 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • package.json: Language not supported

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@heydoyouknowme0 heydoyouknowme0 requested a review from Copilot April 16, 2025 05:36
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR integrates faculty-specific features by updating database schemas, translating new labels, and refactoring several profile components to support faculty data.

  • Updated faculty schema with new tables (qualifications, experience, projects, etc.) and relations.
  • Added new keys for external links and intellectual contributions in translations.
  • Refactored profile and layout components to conditionally render faculty versus personal views.

Reviewed Changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
server/db/schema/faculty.schema.ts Modified the faculty table and added multiple related tables to support faculty integration.
i18n/translations.ts, i18n/hi.ts, i18n/en.ts Introduced new translation keys for faculty external links and intellectual contributions.
app/[locale]/profile/personal/utils.tsx, page.tsx Refactored personal profile component to use a shared utility and integrate with new faculty routing.
app/[locale]/profile/page.tsx, layout.tsx, client-utils.tsx Updated routing, tab creation, and navigation to separate faculty from student profiles.
app/[locale]/faculty-and-staff/... Added new components and layouts to support faculty section views based on employee ID and section parameter.
Files not reviewed (1)
  • package.json: Language not supported
Comments suppressed due to low confidence (2)

server/db/schema/faculty.schema.ts:63

  • [nitpick] The column name 'about' used for the 'field' property in the qualifications table might be misleading. Consider renaming it to 'field' to maintain consistency with the property name.
  field: text('about').notNull(),

app/[locale]/profile/client-utils.tsx:133

  • [nitpick] The CSS class 'lg:size-5' appears non-standard; please verify if this is the intended styling or if a different Tailwind utility class was meant.
              <Icon className="lg:size-5" />

@GetPsyched
Copy link
Member

GetPsyched commented Apr 16, 2025

So many bogus PR comments filling up my screen for nothing

@heydoyouknowme0
Copy link
Contributor Author

heydoyouknowme0 commented Apr 20, 2025

@aryansri-19 review db changes
Edit: I think we better names for the sponsoredprojects and doctorates table

@heydoyouknowme0 heydoyouknowme0 force-pushed the feature/faculty-integration branch from a102df2 to 542e2c3 Compare June 9, 2025 19:11
@heydoyouknowme0 heydoyouknowme0 changed the base branch from faculty-schema to master June 9, 2025 19:13
@heydoyouknowme0 heydoyouknowme0 force-pushed the feature/faculty-integration branch from 542e2c3 to 6c77dd5 Compare June 10, 2025 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants