-
Notifications
You must be signed in to change notification settings - Fork 14
feat: faculty integration #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 15 out of 16 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- package.json: Language not supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR integrates faculty-specific features by updating database schemas, translating new labels, and refactoring several profile components to support faculty data.
- Updated faculty schema with new tables (qualifications, experience, projects, etc.) and relations.
- Added new keys for external links and intellectual contributions in translations.
- Refactored profile and layout components to conditionally render faculty versus personal views.
Reviewed Changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| server/db/schema/faculty.schema.ts | Modified the faculty table and added multiple related tables to support faculty integration. |
| i18n/translations.ts, i18n/hi.ts, i18n/en.ts | Introduced new translation keys for faculty external links and intellectual contributions. |
| app/[locale]/profile/personal/utils.tsx, page.tsx | Refactored personal profile component to use a shared utility and integrate with new faculty routing. |
| app/[locale]/profile/page.tsx, layout.tsx, client-utils.tsx | Updated routing, tab creation, and navigation to separate faculty from student profiles. |
| app/[locale]/faculty-and-staff/... | Added new components and layouts to support faculty section views based on employee ID and section parameter. |
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (2)
server/db/schema/faculty.schema.ts:63
- [nitpick] The column name 'about' used for the 'field' property in the qualifications table might be misleading. Consider renaming it to 'field' to maintain consistency with the property name.
field: text('about').notNull(),
app/[locale]/profile/client-utils.tsx:133
- [nitpick] The CSS class 'lg:size-5' appears non-standard; please verify if this is the intended styling or if a different Tailwind utility class was meant.
<Icon className="lg:size-5" />
|
So many bogus PR comments filling up my screen for nothing |
4bba5cb to
c408089
Compare
|
@aryansri-19 review db changes |
c408089 to
d20e7c8
Compare
d20e7c8 to
48a1be1
Compare
48a1be1 to
851459b
Compare
851459b to
a102df2
Compare
a102df2 to
542e2c3
Compare
542e2c3 to
6c77dd5
Compare
6c77dd5 to
485bc02
Compare
No description provided.