Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More patches ported from poi v3.16 #1371

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

antony-liu
Copy link
Collaborator

More patches ported from poi v3.16

@tonyqus tonyqus added this to the NPOI 2.7.2 milestone Jun 26, 2024
@tonyqus
Copy link
Member

tonyqus commented Aug 31, 2024

Can you check my review comments?

@antony-liu
Copy link
Collaborator Author

什么内容,没看到啊。

@tonyqus
Copy link
Member

tonyqus commented Sep 5, 2024

Can you see my reviews here?
image

@antony-liu
Copy link
Collaborator Author

This modification is based on the toString method in POI. The toString method in POI is gradually being adjusted to this form. Do you want to use StringBuilder in all ToString methods, or just use it here?

@tonyqus
Copy link
Member

tonyqus commented Sep 7, 2024

Just AS IS. No need to follow POI for this. We just follow POI for its feature.

Can you see other reviews?

@antony-liu
Copy link
Collaborator Author

No, I didn't see the previous comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants