-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
index page ui improvementation #121
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request @akaashvaa, look pretty awesome. I'll prioritize reviewing it this week.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @akaashvaa for this. Looks like a really good improvement over the old UI. Would lean on @nishantwrp for further review.
A little worried about the mobile view for sidebar. I think this can be moved to left side of the screen with a margin of 10px like earlier. Maybe, also retain the sliding animation.
src/pages/index.jsx
Outdated
style={{ | ||
margin: "2rem 0", | ||
textAlign: "center", | ||
}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be defined in index.css
.
src/layouts/layout.css
Outdated
:root { | ||
--background: rgba(255, 255, 255, 1); | ||
--card: rgba(237, 237, 237, 1); | ||
--primary: rgba(247, 247, 247, 0.9); | ||
--primary-foreground: rgba(240, 240, 240, 1); | ||
--secondary: rgba(127, 127, 127, 1); | ||
--secondary-foreground: rgba(237, 237, 237, 1); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. Looks neat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Screencast.from.07-07-24.07.25.58.PM.IST.webm
Checkpoint
- moved sidebar to the left of the screen along with animation
- moved style attribute property to index.css
changes
- GSOC Organization logo added
- added a button for scroll to the top ( bottom right corner )
- total no of result (style changed)
- card styles chnaged
- tried to put the technology container at the bottom
let me know if anything else i missed after then i will commit the changes.
i also want to add some feature :
- how about adding the style lint to orgainise the css baised on the order of their property or alphabetically
- apply lazy loading for performance
if u agree then i happy to create an issue on this
let me know if i missed something.
Screencast from 10-06-24 01:24:54 AM IST.webm