MRG: use get_fdata in docs #637
Conversation
We will soonish deprecate get_data, so remove from the docs now, so as not to trip up new users.
matthew-brett
force-pushed
the
docs-using-get-fdata
branch
from
fe69514 to
3fbfb6a
Compare
Codecov Report
@@ Coverage Diff @@
## master #637 +/- ##
==========================================
+ Coverage 88.81% 88.83% +0.01%
==========================================
Files 92 92
Lines 11278 11278
Branches 1848 1848
==========================================
+ Hits 10017 10019 +2
+ Misses 926 925 -1
+ Partials 335 334 -1
Continue to review full report at Codecov.
|
doc/source/nibabel_images.rst
Outdated
| There was no cast, so the array returned is exactly the array attached to the image: | ||
|
|
||
| >>> image_data is array_img.dataobj | ||
| False |
There was a problem hiding this comment.
I might be misreading, but from the above sentence, I'd think this ought to be:
>>> farray_data is farray_img.dataobj
TrueThere was a problem hiding this comment.
Good spot - you're right, but then this test fails, revealing the bug I think I have fixed in #638
|
This PR needs to be merged after #638 (with fixes suggested above). |
Float64 array images return the array from get_fdata, with default input arguements, but other data types return the array cast to float64. Tests will fail before merge of fix in nipy#638 .
|
These stochastic AppVeyor failures seem to be cropping up again. Are you okay if I just go ahead and merge? |
|
Yes, go for it ... |
We will soonish deprecate get_data, so remove from the docs now, so as
not to trip up new users.