ENH: Use appropriate message when reporting TCK file attribute error
#1422
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1422 +/- ##
=======================================
Coverage 95.34% 95.34%
=======================================
Files 209 209
Lines 29780 29780
Branches 3357 3357
=======================================
Hits 28393 28393
Misses 948 948
Partials 439 439 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Use appropriate message when reporting `file` attribute error in TCK: the previous message was mistakenly reporting the non-existence of the `file` attribute, which indeed has to exist to be able to do the `hdr['file']` without getting a `KeyError`. This patch set uses the message that was not being used when the check was not being successful.
jhlegarreta
force-pushed
the
UseAppropriateMsgInTckError
branch
from
3993b97 to
9805f6e
Compare
|
@effigies this is ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use appropriate message when reporting
fileattribute error in TCK: the previous message was mistakenly reporting the non-existence of thefileattribute, which indeed has to exist to be able to do thehdr['file']without getting aKeyError. This patch set uses the message that was not being used when the check was not being successful.