ENH: Allow path-like objects for tractogram load/saving #1421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1421 +/- ##
=======================================
Coverage 95.34% 95.34%
=======================================
Files 209 209
Lines 29780 29801 +21
Branches 3357 3361 +4
=======================================
+ Hits 28393 28414 +21
Misses 948 948
Partials 439 439 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jhlegarreta
force-pushed
the
AllowPathlikeTractogramLoadSave
branch
from
5254601 to
e263641
Compare
Allow path-like objects for tractogram load/saving. Crucially, this patch set uses the capabilities of `pathlib.Path` to get the suffix of a filename when detecing the format instead of relying on the `splitext` function of the `os.path` module, which requires a `str` instance. Add the corresponding tests. Change the docstrings to mark the types of the filenames as `path-like` objects instead of only `str` objects.
jhlegarreta
force-pushed
the
AllowPathlikeTractogramLoadSave
branch
from
e263641 to
92e8cb2
Compare
|
@effigies this is ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow path-like objects for tractogram load/saving.
Crucially, this patch set uses the capabilities of
pathlib.Pathto get the suffix of a filename when detecing the format instead of relying on thesplitextfunction of theos.pathmodule, which requires astrinstance.Add the corresponding tests.
Change the docstrings to mark the types of the filenames as
path-likeobjects instead of onlystrobjects.