MRG, FIX: Remove force render #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #289 +/- ##
==========================================
+ Coverage 67.75% 74.94% +7.19%
==========================================
Files 7 7
Lines 2583 2594 +11
Branches 513 514 +1
==========================================
+ Hits 1750 1944 +194
+ Misses 650 475 -175
+ Partials 183 175 -8 |
|
Added Azure as a CI while I was at it |
|
Same failures occur in MNE, but I still think this is worth having since the |
|
@mwaskom feel free to review/merge if you're happy |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over at MNE we have been getting failures that seem to be triggered by the GUI stuff we do when
__del__is called. This hopefully avoids the problem.WIP until we can do some runs in MNE to see if it makes the problem go away.