[TODO] fix for https://github.com/nim-lang/Nim/pull/13642

[timotheecour]

• fix to unblock [RFC] 'walkDir' now has a new 'checkDir' flag, to mimic behaviour of other languages Nim#13642
• the change in src/nimble.nim is done so that packages that put tests in wrong place (eg test instead of tests) don't cause nim CI to fail; after the packages identified in [RFC] 'walkDir' now has a new 'checkDir' flag, to mimic behaviour of other languages Nim#13642 (comment) update their pacakges, the change in this file could be reverted to cause an error, for eg:

nimble test foo # error if no tests dir nor test task
nimble test --allowempty foo # no error if no tests dir nor test task

(refs #558 ; a warning is not enough, default should be error, but that's orthogonal to this PR)

/cc @dom96 the CI error seems mysterious and unrelated to this PR (and I'm also seeing it for another unrelated PR #781), do you know the source of this error?

[dom96]

Err, what? Am I misunderstanding or are you making this change so that errors are ignored by Nimble just so you can get CI to work in Nim's repo? Why don't you remove the offending packages from the test suite instead (or stop nimble test being called for them)? Don't modify Nimble to ignore errors just because some packages are broken.

[timotheecour]

Am I misunderstanding [...]
Don't modify Nimble to ignore errors just because some packages are broken.

They're already being ignored. As explained in nim-lang/Nim#13642 walkDir currently happily ignores errors, eg if dir is invalid/doesn't exist, it's a currently a noop instead of raising. So this PR #780 doesn't introduce any change in semantics, and also avoids breaking nim CI once nim-lang/Nim#13642 is merged.

/cc @dom96 maybe instead of immediately closing my PR, at least wait until I have a chance to respond to your comments?

Why don't you remove the offending packages from the test suite instead (or stop nimble test being called for them)?

• that wouldn't help with the other change that was needed in this PR
• it's the pre-existing behavior
• I can also remove those 3 packages from nim PR if that's the preferred way (but again, the other change is needed)

[timotheecour]

@dom96 could you please re-open?
I've disabled testing (via nimble test) the offending packages from the test suite in important_packages in nim-lang/Nim#13642, but this PR is still needed as explained in previous post. I can also undo the change in src/nimble.nim but that's introducing a change in behavior for nimble (unlike what I did in this PR which did not introduce a change in behavior as far as nimble is concerned)