strmantle: include => import #16223
Closed
strmantle: include => import #16223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI failure is same as |
timotheecour
force-pushed
the
pr_import_strmantle
branch
from
459eabd to
ffc812e
Compare
the fact that HCR doesn't work on OSX (#13999 + |
|
timotheecour
force-pushed
the
pr_import_strmantle
branch
from
ffc812e to
c6833b5
Compare
timotheecour
force-pushed
the
pr_import_strmantle
branch
from
c6833b5 to
f82f603
Compare
|
Maybe continue this PR, Or I take over(make a new PR)? Since tests/dll/nimhcr_integration.nim is disabled :P |
timotheecour
force-pushed
the
pr_import_strmantle
branch
from
f82f603 to
6cbd2c1
Compare
|
This PR can be closed, no special need to import strmantle now. |
|
includes complicate things, but I'll revisit this after #18592 is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @xflywind (we discussed this)