Skip to content

feat: add audio playback API (Phase 1) #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
niklabh merged 7 commits into from
Mar 24, 2026
Merged

feat: add audio playback API (Phase 1) #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
705d333
fix
niklabh Mar 21, 2026
902026e
fmt
niklabh Mar 21, 2026
a8e7ff9
feat: add audio playback API (Phase 1)
niklabh Mar 24, 2026
82487dd
fmt
niklabh Mar 24, 2026
48109a0
feat: add audio duration, looping, and multi-channel support
niklabh Mar 24, 2026
5340a34
CI
niklabh Mar 24, 2026
db54272
fmt
niklabh Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ jobs:
sudo apt-get install -y \
libxcb-render0-dev libxcb-shape0-dev libxcb-xfixes0-dev \
libxkbcommon-dev libssl-dev libgtk-3-dev libatk1.0-dev \
libglib2.0-dev libpango1.0-dev libgdk-pixbuf-2.0-dev
libglib2.0-dev libpango1.0-dev libgdk-pixbuf-2.0-dev \
libasound2-dev

- uses: dtolnay/rust-toolchain@stable
with:
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,8 @@ jobs:
sudo apt-get install -y \
libxcb-render0-dev libxcb-shape0-dev libxcb-xfixes0-dev \
libxkbcommon-dev libssl-dev libgtk-3-dev libatk1.0-dev \
libglib2.0-dev libpango1.0-dev libgdk-pixbuf-2.0-dev
libglib2.0-dev libpango1.0-dev libgdk-pixbuf-2.0-dev \
libasound2-dev

- uses: dtolnay/rust-toolchain@stable
with:
Expand Down
1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ members = [
"oxide-browser",
"oxide-sdk",
"examples/hello-oxide",
"examples/audio-player",
"examples/fullstack-notes/frontend",
"examples/fullstack-notes/backend",
]
Expand Down
16 changes: 8 additions & 8 deletions ROADMAP.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,14 @@ The core architecture is live: a Rust-native browser that fetches and executes `

### Audio

- [ ] `audio_play(data, format)` — decode and play audio buffers (MP3, OGG, WAV, FLAC)
- [ ] `audio_play_url(url)` — stream audio from a URL
- [ ] `audio_pause()` / `audio_resume()` / `audio_stop()` — playback control
- [ ] `audio_set_volume(level)` / `audio_get_volume()` — volume control (0.0–1.0)
- [ ] `audio_seek(position_ms)` / `audio_position()` — seek and query playback position
- [ ] `audio_duration()` — get total duration of loaded track
- [ ] `audio_set_loop(enabled)` — loop playback toggle
- [ ] Multiple simultaneous audio channels for sound effects and background music
- [x] `audio_play(data, format)` — decode and play audio buffers (MP3, OGG, WAV, FLAC)
- [x] `audio_play_url(url)` — stream audio from a URL
- [x] `audio_pause()` / `audio_resume()` / `audio_stop()` — playback control
- [x] `audio_set_volume(level)` / `audio_get_volume()` — volume control (0.0–1.0)
Comment on lines +37 to +40
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Update these bullets to match the shipped API.

Line 37 still documents audio_play(data, format) even though the SDK now exposes audio_play(data), and Line 40 still says volume is 0.0–1.0 while the host accepts up to 2.0. Keeping the roadmap aligned with the public API will avoid misleading app authors.

📝 Suggested doc fix 
-- [x] `audio_play(data, format)` — decode and play audio buffers (MP3, OGG, WAV, FLAC)
+- [x] `audio_play(data)` — decode and play audio buffers (MP3, OGG, WAV, FLAC)

-- [x] `audio_set_volume(level)` / `audio_get_volume()` — volume control (0.0–1.0)
+- [x] `audio_set_volume(level)` / `audio_get_volume()` — volume control (0.0–2.0)
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- [x] `audio_play(data, format)` — decode and play audio buffers (MP3, OGG, WAV, FLAC)
- [x] `audio_play_url(url)` — stream audio from a URL
- [x] `audio_pause()` / `audio_resume()` / `audio_stop()` — playback control
- [x] `audio_set_volume(level)` / `audio_get_volume()` — volume control (0.0–1.0)
- [x] `audio_play(data)` — decode and play audio buffers (MP3, OGG, WAV, FLAC)
- [x] `audio_play_url(url)` — stream audio from a URL
- [x] `audio_pause()` / `audio_resume()` / `audio_stop()` — playback control
- [x] `audio_set_volume(level)` / `audio_get_volume()` — volume control (0.0–2.0)
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@ROADMAP.md` around lines 37 - 40, Update the roadmap bullets to reflect the
shipped API: change the function signature `audio_play(data, format)` to
`audio_play(data)` (remove the `format` parameter), and update the volume range
in `audio_set_volume(level)` / `audio_get_volume()` from "0.0–1.0" to "0.0–2.0";
keep the other entries (`audio_play_url(url)`,
`audio_pause()`/`audio_resume()`/`audio_stop()`) as-is so the list matches the
public SDK surface.

- [x] `audio_seek(position_ms)` / `audio_position()` — seek and query playback position
- [x] `audio_duration()` — get total duration of loaded track
- [x] `audio_set_loop(enabled)` — loop playback toggle
- [x] Multiple simultaneous audio channels for sound effects and background music
- [ ] Audio format detection and codec negotiation

### Video
Expand Down
11 changes: 11 additions & 0 deletions examples/audio-player/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
[package]
name = "audio-player"
version = "0.1.0"
edition = "2021"
description = "Audio playback demo for the Oxide browser"

[lib]
crate-type = ["cdylib"]

[dependencies]
oxide-sdk = { path = "../../oxide-sdk" }
Loading
Loading