Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace template parsing with yaml.Decoder #42

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Replace template parsing with yaml.Decoder #42

wants to merge 2 commits into from

Commits on Aug 28, 2024

  1. Replace template parsing with yaml.Decoder 

    This solves some of the edge cases around parsing for empty or invalid
document by replacing the string splitting with the yaml package's
native handling of multi-document files.

Along the way it also simplifies upstream functions by returning parsed
yaml as a map[string]interface{} instead of a string.
    Phil Kates committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    b951fdd View commit details
    Browse the repository at this point in the history

  2. Fix test error 

    These tests should probably be replaced with a more thorough testing of
the image-regex feature, which appears to currently be broken. This
doesn't break anything and is at least a step in the right direction.
    Phil Kates committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    7d26eaf View commit details
    Browse the repository at this point in the history