Skip to content

Refactor #86: Moved global error handler into a dedicated middleware/… #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jikrana1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor #86: Moved global error handler into a dedicated middleware/… #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions backend/src/middleware/errorHandler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
// middleware/errorHandler.js

const errorHandler = (err, req, res, next) => {
console.error("Error:", err.message);

// प्रोडक्शन में मैसेज न दिखाएं, सिर्फ डेवलपमेंट में दिखाएं (पहले जैसा ही बिहेवियर)
res.status(500).json({
error: "Internal server error",
message: process.env.NODE_ENV === "development" ? err.message : undefined,
});
};

export default errorHandler;
9 changes: 2 additions & 7 deletions backend/src/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import { connectRedis } from "./config/redis.js";

// Middleware
import rateLimiter from "./middleware/rateLimiter.js";
import errorHandler from "./middleware/errorHandler.js";

// ==================== CONFIGURATION ====================
dotenv.config();
Expand Down Expand Up @@ -88,13 +89,7 @@ if (process.env.NODE_ENV === "production") {
}

// ==================== ERROR HANDLING ====================
app.use((err, req, res, next) => {
console.error("Error:", err.message);
res.status(500).json({
error: "Internal server error",
message: process.env.NODE_ENV === "development" ? err.message : undefined,
});
});
app.use(errorHandler);;

// ==================== START SERVER ====================
const startServer = async () => {
Expand Down
Loading