feat: add rate limiting to product create, update, and delete endpoints - #546
Open
swetalin-10 wants to merge 1 commit into
Open
feat: add rate limiting to product create, update, and delete endpoints#546swetalin-10 wants to merge 1 commit into
swetalin-10 wants to merge 1 commit into
Conversation
POST, PUT, PATCH, and DELETE on /api/products had no rate limiting, leaving them open to abuse. Added productCreateLimiter (30/hr), productUpdateLimiter (60/hr), and productDeleteLimiter (20/hr) in rateLimiter.js and wired them up in product.route.js. Closes niharika-mente#329
|
@swetalin-10 is attempting to deploy a commit to the niharika-mente's projects Team on Vercel. A member of the Team first needs to authorize it. |
Aamod007
self-requested a review
July 2, 2026 17:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #329
Problem
The
POST /api/products,PUT /api/products/:id,PATCH /api/products/:id/restock, andDELETE /api/products/:idendpoints had no rate limiting. While they are protected byauthMiddlewareandadminMiddleware, a compromised admin token or a brute-force scenario could still allow mass creation, bulk updates, or rapid deletion of products without any throttling.Solution
Added three new rate limiters in
BACKEND/middleware/rateLimiter.jsfollowing the exact same pattern as the existing auth limiters, and wired them intoBACKEND/routes/product.route.js.productCreateLimiterPOST /api/productsproductUpdateLimiterPUT /api/products/:id,PATCH /api/products/:id/restockproductDeleteLimiterDELETE /api/products/:idDelete has the tightest limit since it's the most destructive operation.
Changes
BACKEND/middleware/rateLimiter.js— added three new exported limiters:BACKEND/routes/product.route.js— imported and applied the limiters before auth checks (so the rate limit fires before any token validation overhead):Full diff: swetalin-10@71bc954
No breaking changes