Skip to content

fix(filters): remove redundant sort options and rename for consistency (closes #140) - #142

Open
arcgod-design wants to merge 1 commit into
niharika-mente:mainfrom
arcgod-design:feat/issue-140-sort-dropdown
Open

fix(filters): remove redundant sort options and rename for consistency (closes #140)#142
arcgod-design wants to merge 1 commit into
niharika-mente:mainfrom
arcgod-design:feat/issue-140-sort-dropdown

Conversation

@arcgod-design

@arcgod-design arcgod-design commented Aug 5, 2026

Copy link
Copy Markdown

Summary

Removes redundant/duplicate sort options and renames the remaining ones for consistency.

Changes

  • Dropped confusing duplicate labels
  • Renamed "Date (Latest First)" → "Date (Newest First)" (matches the issue's expected label)
  • Renamed "Date (Earliest First)" → "Date (Oldest First)" (matches the issue's expected label)

Before

  • "Newest First"
  • "Date (Earliest First)"
  • "Date (Latest First)" ← duplicate of Newest First
  • "Popularity (Most Booked)"
  • "Name (A–Z)"
  • "Name (Z–A)"

After

  • "Date (Newest First)"
  • "Date (Oldest First)"
  • "Popularity (Most Booked)"
  • "Name (A–Z)"
  • "Name (Z–A)"

Verification

The default empty-value option still maps to date_desc via the API switch statement (app/api/events/route.ts), so the existing "newest events by default" behaviour is preserved.

Closes #140

Summary by CodeRabbit

  • Style
    • Updated sorting labels from “Latest/Earliest” to “Newest/Oldest” for clearer wording.
    • Sorting behavior remains unchanged.

closes niharika-mente#140)

- Drop duplicate/confusing date labels
- Standardize labels: Date (Newest First), Date (Oldest First), Popularity (Most Booked), Name (A–Z), Name (Z–A)
@vercel

vercel Bot commented Aug 5, 2026

Copy link
Copy Markdown

@arcgod-design is attempting to deploy a commit to the niharika-mente's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 94129105-bc76-40ad-955c-1de49682c545

📥 Commits

Reviewing files that changed from the base of the PR and between 7dc2a03 and cbbf51d.

📒 Files selected for processing (1)
  • components/SearchFilters.tsx

📝 Walkthrough

Walkthrough

The sort dropdown labels now use “Date (Newest First)” and “Date (Oldest First)”. Sorting values and behavior remain unchanged.

Changes

Sort label cleanup

Layer / File(s) Summary
Update date sort labels
components/SearchFilters.tsx
Renames the date sort labels without changing their values or behavior.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: tarunyaprogrammer

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The change renames two labels but does not remove the duplicate “Newest First” option required by issue #140. Remove the redundant “Newest First” entry and verify that the dropdown contains exactly the five unique options required by issue #140.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the redundant sort-option change and label consistency updates related to issue #140.
Description check ✅ Passed The description summarizes the change, issue, expected labels, and behavior verification, but omits type and checklist details.
Out of Scope Changes check ✅ Passed The changes are limited to sort-option labels and remain within the scope of issue #140.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Redundant and duplicate sorting options in 'Sort by' dropdown

1 participant