fix: don't drop the whole cache when the web storage quota is full - #25
Merged
Merged
Conversation
… storage quota is full
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
localStorageorsessionStoragerefused a write because the quota was full, the store calledclear(): one response too big for the quota threw away the entire cache, small entries included.Worse, the error was recognized only by the name
QuotaExceededError, which is what Chrome and Safari use. Firefox reportsNS_ERROR_DOM_QUOTA_REACHED(code 1014) and some browsers only set the legacy code 22, so there the branch never ran: the write was silently lost and the storage stayed full, making every later write fail too.Now the error is recognized by name and by code, and the default recovery evicts the oldest entries one at a time until the new one fits.
onQuotaExceeded('evict-oldest', 'clear', 'ignore') andmaxQuotaRetryare options ofwithNgHttpCachingLocalStorage()andwithNgHttpCachingSessionStorage().Nine tests, including one per error flavour, all checked that they fail without the change.