Repository navigation
Isolate docs eval tools and retain final evidence - #677
Merged
Merged
Conversation
Expose only exact selected MCP tools, retain bounded post-result metadata with conservative semantics, and credit Azure search proof independently of row validity. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2fce2ecd-5a59-4d80-96ff-a5e9e09bc60d
Fail closed on truncated post-result tails, require selected or builtin lifecycle identities, and enforce exact configured tool membership in scorer and Azure proof. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2fce2ecd-5a59-4d80-96ff-a5e9e09bc60d
Retain structured identity, status alias, and error-field evidence so runner and scorer reject foreign, unnamed, duplicate, conflicting, or malformed MCP lifecycle postambles. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2fce2ecd-5a59-4d80-96ff-a5e9e09bc60d
Assert scorer rejects foreign and error-bearing loaded server summaries alongside foreign and unnamed lifecycle metadata. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2fce2ecd-5a59-4d80-96ff-a5e9e09bc60d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deferTools: "never", one config, built-in MCP disablement, and server permissionmcp.tools.list_changedrequires exactly the selected server identity, no status, no error/failure fields, and ephemeral=truegithub-mcp-serverdisabled, with consistent aliases and no error fieldsArtifact
8755138625cannot reveal prior exact post-result types because all affected excerpts truncate before the result; this PR closes that gap conservatively.Validation
python -m pytest tests\test_docs_eval_evidence.py -q— 322 passed, 2 POSIX-specific tests skipped on Windowspython -m ruff check scripts\run_docs_eval.py scripts\eval_scorer.py tests\test_docs_eval_evidence.py— passedDo not merge or rerun the full matrix until reviewed.