-
Notifications
You must be signed in to change notification settings - Fork 98
Adding and removing few methods and few more fixes in RFSG #2121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2121 +/- ##
==========================================
+ Coverage 88.99% 89.21% +0.22%
==========================================
Files 71 71
Lines 18950 18820 -130
==========================================
- Hits 16864 16790 -74
+ Misses 2086 2030 -56
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
I won't hold up this PR for it, but Lo1OutputFilter enum values are missing descriptions. |
|
test_waveform_rep_cap --> test_waveforms_rep_cap |
|
Looking at Something about our codegen that you should be aware of: by default we trim common prefixes in the enum value names for a given enum. This is how we get rid of NIRFSG_VAL in the above enum values. But this also means that "5.5GHz_" is not part of the enum value name for either. This may or may not be what's desired. You can override this behavior by specifying the You may want to go through your generated enums.py to look for any enum values that aren't what you want. |
|
Fixed the repcap test names. For enums, it turns out the enums which had numbers in names are not used by any attribute or function. I've gone ahead and turned off generation for them. No 'yet to be defined' descriptions anymore in enums. Also, caught a wrong unit name case while looking into this, so fixed that. |
I'd advise against setting codegen_method: "public" for enums, as you may be generating something that's unused. |
I've updated CHANGELOG.md if applicable.What does this Pull Request accomplish?
List issues fixed by this Pull Request below, if any.
None
What testing has been done?
System tests for newly added API and updated enum names all pass on simulated and real hardware.