[DO NOT MERGE UNTIL 25C2] Upgrade to Python 3.9 syntax #681
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contribution adheres to CONTRIBUTING.md.
I've updated CHANGELOG.md if applicable.I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
Use PEP 585 – Type Hinting Generics In Standard Collections and do other Python 3.9 syntax upgrades:
Get-ChildItem -Recurse "*.py" | ForEach-Object { pyupgrade --py39-plus $_ }
using the latest pyupgrade (installed via pipx).Use PEP 604 – Allow writing union types as X | Y where possible:
from __future__ import annotations
to most files containingfrom typing import ...
. This allows using type hint syntax from the future.X | Y
syntax if the file already hasfrom __future__ import annotations
.I did not remove the hardcoded
Optional[...]
references from docstrings.Why should this Pull Request be merged?
Reduce number of
typing
imports.Remove usage of
typing.Optional
, which people often confuse with default arguments.What testing has been done?
Ran ni-python-styleguide, mypy, and pytest locally.