Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for Python 3.8 #1076

Merged
merged 3 commits into from
Mar 6, 2025
Merged

Conversation

bkeryan
Copy link
Collaborator

@bkeryan bkeryan commented Mar 6, 2025

What does this Pull Request accomplish?

Remove support for Python 3.8.

Why should this Pull Request be merged?

NI's Python support policy says:

NI products that support or integrate with Python will drop official support for all Python versions that have reached their end of life EOL . This should be done at the next release of the product following the EOL date for a given Python version

Also, more of measurement-plugin-python's dependencies (e.g. protobuf) have started to drop Python 3.8 support.

What testing has been done?

PR build.

@bkeryan bkeryan requested a review from mshafer-NI as a code owner March 6, 2025 01:12
Copy link

github-actions bot commented Mar 6, 2025

Test Results

    32 files   -     8      32 suites   - 8   45m 45s ⏱️ - 12m 11s
   707 tests ±    0     707 ✅ ±    0    0 💤 ±  0  0 ❌ ±0 
13 768 runs   - 3 442  12 912 ✅  - 3 228  856 💤  - 214  0 ❌ ±0 

Results for commit 4374b4d. ± Comparison against base commit 9491f6b.

♻️ This comment has been updated with latest results.

@bkeryan bkeryan merged commit d13a152 into main Mar 6, 2025
15 checks passed
@bkeryan bkeryan deleted the users/bkeryan/remove-python-3.8 branch March 6, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants