Async rule changes

change/@ni-eslint-config-angular-225ce3da-b49d-4df7-ace0-b99abb8fbcb0.json

@@ -0,0 +1,7 @@
+{
+  "type": "minor",
+  "comment": "Rule changes for asynchronous code:\\n 1. Functions marked `async` must now include an `await`. The rule `'@typescript-eslint/require-await'` changed from `'off'` to `'error'`.\\n 2. Test code must now correctly handle promises. The rule `'@typescript-eslint/no-floating-promises'` changed from `'off'` to `'error'`.",
+  "packageName": "@ni/eslint-config-angular",
+  "email": "[email protected]",
+  "dependentChangeType": "patch"
+}

change/@ni-eslint-config-javascript-4569f2fb-83ed-4863-9f95-96f907ede343.json

@@ -0,0 +1,7 @@
+{
+  "type": "minor",
+  "comment": "Rule changes for asynchronous code:\\n 1. Functions marked `async` must now include an `await`. The rule `'require-await'` changed from `'off'` to `'error'`.\\n 2. It is now acceptable for a function to return an awaited promise. The rule `'no-return-await'` changed from `'error'` to `'off'`.",
+  "packageName": "@ni/eslint-config-javascript",
+  "email": "[email protected]",
+  "dependentChangeType": "patch"
+}

change/@ni-eslint-config-typescript-32797652-8b30-47bc-b259-dfe598d5a4e3.json

@@ -0,0 +1,7 @@
+{
+  "type": "minor",
+  "comment": "Rule changes for asynchronous code:\\n 1. Functions marked `async` must now include an `await`. The rule `'@typescript-eslint/require-await'` changed from `'off'` to `'error'`.",
+  "packageName": "@ni/eslint-config-typescript",
+  "email": "[email protected]",
+  "dependentChangeType": "patch"
+}

packages/eslint-config-angular/requiring-type-checking.js

@@ -8,10 +8,9 @@ module.exports = {
             files: ['*.spec.ts'],
             rules: {
                 /*
-                    The jasminewd2 library used by Angular applications results in a significant number of
-                    floating promises and unbound methods so these rules are disabled for test specs in Angular projects.
+                    Spies used by Angular application tests result in a significant number of
+                    unbound methods so this rule is disabled for test specs in Angular projects.
                 */
-                '@typescript-eslint/no-floating-promises': 'off',
                 '@typescript-eslint/unbound-method': 'off',
             }
         },

packages/eslint-config-javascript/index.js

@@ -325,6 +325,11 @@ module.exports = {
                 selector: 'CallExpression[callee.object.name=\'console\'][callee.property.name=/^(debug|info|time|timeEnd|trace)$/]',
                 message: 'Unexpected property on console object was called'
             }],
+        /*
+            This rule is deprecated since ESLint 8.46.0 because returning an awaited value no longer generates an extra microtask.
+            https://eslint.org/docs/latest/rules/no-return-await
+        */
+        'no-return-await': 'off',
 
         /*
             Disallow returning values from setters.
@@ -424,6 +429,8 @@ module.exports = {
         */
         'prefer-regex-literals': 'error',
 
+        'require-await': 'error',
+
         /*
             This configuration already supports the JSDoc syntax. Add additional syntax as line or
             block exceptions or markers when necessary.

packages/eslint-config-typescript/lib/extensions-requiring-type-checking.js

@@ -12,9 +12,9 @@ module.exports = {
         'no-throw-literal': 'off',
         '@typescript-eslint/no-throw-literal': 'error',
 
-        // Defined by Airbnb
+        // Defined by NI
         'require-await': 'off',
-        '@typescript-eslint/require-await': 'off',
+        '@typescript-eslint/require-await': 'error',
 
         // Defined by Airbnb
         'no-return-await': 'off',

tests/angular/custom-ignore-attributes/index.spec.ts

@@ -18,7 +18,7 @@ describe('MyComponent', () => {
     it('should have a div', async () => {
         await fixture.whenStable();
 
-        expect(hostComponent.div).toBeDefined();
-        expect(hostComponent.myMethod).not.toHaveBeenCalled();
+        await expect(hostComponent.div).toBeDefined();
+        await expect(hostComponent.myMethod).not.toHaveBeenCalled();
     });
 });

tests/angular/index.spec.ts

@@ -18,7 +18,7 @@ describe('MyComponent', () => {
     it('should have a div', async () => {
         await fixture.whenStable();
 
-        expect(hostComponent.div).toBeDefined();
-        expect(hostComponent.myMethod).not.toHaveBeenCalled();
+        await expect(hostComponent.div).toBeDefined();
+        await expect(hostComponent.myMethod).not.toHaveBeenCalled();
     });
 });

tests/javascript/index.js

@@ -12,4 +12,8 @@ export class NI {
     makeAwesomer() {
         this._awesomeLevel += 1;
     }
+
+    async asyncAwesomeness() {
+        await new Promise();
+    }
 }

tests/typescript-requiring-type-checking/index.ts

@@ -10,4 +10,10 @@ export class NI {
     public makeAwesomer(): void {
         this._awesomeLevel += 1;
     }
+
+    public async asyncAwesomeness(): Promise<void> {
+        await new Promise(resolve => {
+            resolve(true);
+        });
+    }
 }