Update data.client and metadata.client package dependencies to the latest #63
Conversation
- Updated __slots__, __init__ parameters, and field assignments - Updated from_protobuf and to_protobuf methods - Updated __eq__ method and docstring - Updated all test files to use new field names - Maintains compatibility with protobuf schema
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes field naming across the codebase by removing redundant prefixes from attribute names in data and metadata types. The changes update field names like operator_name to name, test_station_name to name, step_name to name, etc., making the API more concise while maintaining clarity through object types. The PR also updates dependencies to newer versions and adds new fields (error_information, outcome) to Step and TestResult types.
- Renamed attributes to remove redundant type prefixes (e.g.,
operator_name→name) - Added
error_informationandoutcomefields to Step type - Added
error_informationfield to TestResult type - Updated measurement and condition field names (
measurement_name→name,condition_name→name) - Updated proto client dependencies to version 0.2.0.dev0
- Updated all tests and examples to use new naming conventions
Reviewed Changes
Copilot reviewed 38 out of 40 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/ni/datastore/metadata/_types/*.py | Updated metadata type classes to use simplified field names |
| src/ni/datastore/data/_types/*.py | Updated data type classes with new field names and added error/outcome fields |
| tests/unit/**/*.py | Updated unit tests to use new field naming |
| tests/acceptance/*.py | Updated acceptance tests to use new field naming |
| pyproject.toml | Updated proto client dependencies to 0.2.0.dev0 |
| poetry.lock | Updated dependency versions |
| examples/**/*.py, *.ipynb | Updated examples to use new field naming |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hunter-ni
left a comment
hunter-ni
left a comment
There was a problem hiding this comment.
Approve with Suggestions. Just let me know if you want to discuss or want me to look again.
What does this Pull Request accomplish?
Updates the dependencies on the
data.clientandmetadata.clientpackages to be the latest versions. This includes some name changes and field changes / additions we want to uptake.Why should this Pull Request be merged?
Keep our API matching the .proto gRPC API.
What testing has been done?
PR passing with tests. Will manually verify notebooks / examples.