Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change periodicity to once a quarter #26

Merged
merged 2 commits into from
Oct 27, 2024
Merged

chore: change periodicity to once a quarter #26

merged 2 commits into from
Oct 27, 2024

Conversation

dbarrosop
Copy link
Member

@dbarrosop dbarrosop commented Oct 27, 2024

PR Type

Enhancement


Description

  • Updated GitHub Actions runner names in push_build_devShells.yaml:
    • Replaced ubuntu-22.04 with blacksmith-2vcpu-ubuntu-2204
    • Replaced ubuntu-arm64-22.04-2cores with blacksmith-2vcpu-ubuntu-2204-arm
  • Changed the schedule for updating dependencies in schedule_update_deps.yaml:
    • Modified cron job to run quarterly instead of monthly
  • These changes aim to improve the CI/CD pipeline by using more specific runner names and optimizing the frequency of dependency updates.

Changes walkthrough 📝

Relevant files
Configuration changes
push_build_devShells.yaml
Update GitHub Actions runner names                                             

.github/workflows/push_build_devShells.yaml

  • Updated the os matrix to use new runner names:
    blacksmith-2vcpu-ubuntu-2204 and blacksmith-2vcpu-ubuntu-2204-arm
  • +1/-1     
    schedule_update_deps.yaml
    Adjust dependency update schedule                                               

    .github/workflows/schedule_update_deps.yaml

  • Modified the cron schedule from monthly to quarterly by changing '0 2
    27 * *' to '0 2 27 */3 *'
  • +1/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Runner Compatibility
    Verify that the new runner names 'blacksmith-2vcpu-ubuntu-2204' and 'blacksmith-2vcpu-ubuntu-2204-arm' are correctly configured and available in the GitHub Actions environment.

    Schedule Frequency
    Confirm that changing the dependency update schedule from monthly to quarterly aligns with the project's needs and doesn't introduce risks of using outdated dependencies for extended periods.

    Copy link
    Contributor

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Possible issue
    Adjust cron schedule to ensure consistent quarterly execution, avoiding potential skips due to varying month lengths

    **The cron expression '0 2 27 /3 ' will run the job at 2 AM on the 27th day of every
    3rd month. Be aware that this schedule will skip months that don't have a 27th day
    (February in non-leap years). Consider adjusting if you want it to run consistently
    every quarter.

    .github/workflows/schedule_update_deps.yaml [4-5]

     schedule:
    -  - cron: '0 2 27 */3 *'
    +  - cron: '0 2 1 */3 *'
    Suggestion importance[1-10]: 8

    Why: This suggestion addresses a potential issue with the cron schedule that could lead to inconsistent job execution. The proposed change ensures the job runs reliably every quarter, which is likely the intended behavior.

    8
    Maintainability
    Use more generic and descriptive names for OS matrix values to improve clarity and portability

    Consider using more descriptive names for the OS matrix values. The current names
    are specific to a particular CI/CD environment and may not be clear to all team
    members or in different contexts.

    .github/workflows/push_build_devShells.yaml [12-13]

     matrix:
    -  os: [blacksmith-2vcpu-ubuntu-2204, blacksmith-2vcpu-ubuntu-2204-arm]
    +  os: [ubuntu-22.04-x86, ubuntu-22.04-arm]
    Suggestion importance[1-10]: 6

    Why: The suggestion improves code readability and maintainability by using more generic OS names. However, it's not a critical change and the existing names might be intentionally specific to the CI/CD environment.

    6

    @dbarrosop dbarrosop merged commit 939fe65 into main Oct 27, 2024
    2 checks passed
    @dbarrosop dbarrosop deleted the period branch October 27, 2024 07:37
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant