Merge pull request #11 from ngxpert/ng-update-18

Ng update 18
ngxpert · Jun 6, 2024 · 33d33d1 · 33d33d1
2 parents 77cb028 + 27546ad
commit 33d33d1
Show file tree

Hide file tree

Showing 17 changed files with 10,992 additions and 31,890 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -1,37 +1,46 @@
 {
   "root": true,
-  "ignorePatterns": ["projects/**/*"],
-  "parser": "@typescript-eslint/parser",
-  "plugins": ["@typescript-eslint", "@angular-eslint", "prefer-arrow"],
+  "ignorePatterns": [
+    "projects/**/*"
+  ],
   "overrides": [
     {
-      "files": ["*.ts"],
-      "parserOptions": {
-        "project": ["tsconfig.json"],
-        "createDefaultProgram": true
-      },
+      "files": [
+        "*.ts"
+      ],
+      "extends": [
+        "eslint:recommended",
+        "plugin:@typescript-eslint/recommended",
+        "plugin:@angular-eslint/recommended",
+        "plugin:@angular-eslint/template/process-inline-templates"
+      ],
       "rules": {
-        "@angular-eslint/component-selector": [
+        "@angular-eslint/directive-selector": [
           "error",
           {
-            "type": "element",
+            "type": "attribute",
             "prefix": "app",
-            "style": "kebab-case"
+            "style": "camelCase"
           }
         ],
-        "@angular-eslint/directive-selector": [
+        "@angular-eslint/component-selector": [
           "error",
           {
-            "type": "attribute",
+            "type": "element",
             "prefix": "app",
-            "style": "camelCase"
+            "style": "kebab-case"
           }
         ]
       }
     },
     {
-      "files": ["*.html"],
-      "extends": ["plugin:@angular-eslint/template/recommended"],
+      "files": [
+        "*.html"
+      ],
+      "extends": [
+        "plugin:@angular-eslint/template/recommended",
+        "plugin:@angular-eslint/template/accessibility"
+      ],
       "rules": {}
     }
   ]

diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
@@ -25,4 +25,4 @@ jobs:
           npm run build -- --base-href "/hot-toast/"
           npm run build:lib
           npx semantic-release
-          npx angular-cli-ghpages --name="mr. Dharmen's Bot" [email protected] --dir=dist/toast
+          npx angular-cli-ghpages --name="mr. Dharmen's Bot" [email protected] --dir=dist/toast/browser
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -39,8 +39,8 @@ jobs:
           GH_TOKEN: ${{ secrets.GH_TOKEN }}
           NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
         run: |
-          npm run lint
+          npm run lint -- @ngxpert/hot-toast
+          npm run build:lib
           npm run build
           npm run test
-          npm run build:lib
           npx semantic-release --debug
diff --git a/README.md b/README.md
@@ -34,7 +34,15 @@ https://github.com/ngxpert/hot-toast/assets/6831283/ae718568-d5ea-47bf-a41d-6aab
         1.x, 2.x
       </td>
       <td>
-        >= 17
+        >= 17 < 18
+      </td>
+    </tr>
+    <tr>
+      <td>
+        3.x
+      </td>
+      <td>
+        >= 18
       </td>
     </tr>
   </tbody>

diff --git a/angular.json b/angular.json
@@ -15,24 +15,33 @@
       "prefix": "app",
       "architect": {
         "build": {
-          "builder": "@angular-devkit/build-angular:browser",
+          "builder": "@angular-devkit/build-angular:application",
           "options": {
-            "outputPath": "dist/toast",
+            "outputPath": {
+              "base": "dist/toast"
+            },
             "index": "src/index.html",
-            "main": "src/main.ts",
-            "polyfills": "src/polyfills.ts",
+            "polyfills": [
+              "src/polyfills.ts"
+            ],
             "tsConfig": "tsconfig.app.json",
             "aot": true,
-            "assets": ["src/assets"],
-            "styles": ["src/styles.scss", "node_modules/prismjs/themes/prism-okaidia.min.css"],
+            "assets": [
+              "src/assets"
+            ],
+            "styles": [
+              "src/styles.scss",
+              "node_modules/prismjs/themes/prism-okaidia.min.css"
+            ],
             "scripts": [],
-            "allowedCommonJsDependencies": ["prismjs"]
+            "allowedCommonJsDependencies": [
+              "prismjs"
+            ],
+            "browser": "src/main.ts"
           },
           "configurations": {
             "development": {
-              "buildOptimizer": false,
               "optimization": false,
-              "vendorChunk": true,
               "extractLicenses": false,
               "sourceMap": true,
               "namedChunks": true
@@ -49,8 +58,6 @@
               "sourceMap": false,
               "namedChunks": false,
               "extractLicenses": true,
-              "vendorChunk": false,
-              "buildOptimizer": true,
               "budgets": [
                 {
                   "type": "initial",
@@ -85,7 +92,10 @@
         "lint": {
           "builder": "@angular-eslint/builder:lint",
           "options": {
-            "lintFilePatterns": ["src/**/*.ts", "src/**/*.html"]
+            "lintFilePatterns": [
+              "src/**/*.ts",
+              "src/**/*.html"
+            ]
           }
         },
         "e2e": {
@@ -126,7 +136,10 @@
         "lint": {
           "builder": "@angular-eslint/builder:lint",
           "options": {
-            "lintFilePatterns": ["projects/ngxpert/hot-toast/**/*.ts", "projects/ngxpert/hot-toast/**/*.html"]
+            "lintFilePatterns": [
+              "projects/ngxpert/hot-toast/**/*.ts",
+              "projects/ngxpert/hot-toast/**/*.html"
+            ]
           }
         }
       }
-Original file line number
+Diff line change
@@ Expand Up @@
 .x, 2.x
           </td>
           <td>
-            >= 17
+            >= 17 < 18
+          </td>
+        </tr>
+        <tr>
+          <td>
+.x
+          </td>
+          <td>
+            >= 18
           </td>
         </tr>
       </tbody>
@@ Expand Down @@