Quoted double parsing#284
Open
mark-b2c2 wants to merge 2 commits into
Open
Conversation
Member
|
Thanks for the PR. |
Author
|
Thanks for the feedback. I wanted to see if you were agreeable to the change to begin with. I will improve test coverage in the next couple of days and revert when complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @zapov,
I was profiling an app of ours using your fantastic serialization library and I saw that deserializing quoted doubles was causing excessive creation of strings due to the code falling back to
Double.parseDoubleinparseDoubleGeneric.Please take a look at this PR and advise if this approach looks reasonable and what else you think needs completing in order to consider merging the change.