Skip to content

Conversation

@timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

We provide all rules in the predefined configs, including the ones that requires type checking. Type checking is automatically enabled, and the configs uses the tsconfig.json file as project.

Closes #4993
Closes #4903

What is the new behavior?

Rules that require typechecking are excluded by default, and can be enabled by using the abcTypeChecked config. When the user opts into this behavior, the user is also required to configure the correct parsing options.

This is similar to https://typescript-eslint.io/getting-started/typed-linting/

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

The current set up can be difficult to configure when using multiple projects and/or multiple tsconfig files. I expect this to become a problem on new projects that make of tsconfig.json (with references) and tsconfig.app.json files.

@netlify
Copy link

netlify bot commented Nov 18, 2025

Deploy Preview for ngrx-site-v19 ready!

Name Link
🔨 Latest commit 80db465
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-site-v19/deploys/691e17774cb25800081e3813
😎 Deploy Preview https://deploy-preview-5002--ngrx-site-v19.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 18, 2025

Deploy Preview for ngrx-io canceled.

Name Link
🔨 Latest commit 80db465
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-io/deploys/691e17776a5d1800071d7ffe

@timdeschryver timdeschryver merged commit c1f4fc5 into main Nov 20, 2025
14 checks passed
@timdeschryver timdeschryver deleted the eslint-typechecking branch November 20, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

4 participants