Modernize build to use pyproject.toml and scikit-build-core #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi @jbcoe , thanks for putting this together. I'm not totally sure how to validate the changes, and get an error (not to say I didn't before!). Does the README need some updates as well. |
Author
|
There's a fair bit of work still to do here (hence the draft status), I thought I'd open the PR for visibility. I was talking to the maintainers of NetHack LE (https://github.com/NetHack-LE/nle) and wondering if this project (nethack language wrapper) is still active? We'd be keen to update the nethack langauge wrapper to work with latest version of Nethack LE. |
Current issues with build
CMake Error at /usr/share/cmake-3.31/Modules/FindPackageHandleStandardArgs.cmake:233 (message):
Could NOT find Python (missing: Interpreter) (found suitable version
3.10.18, minimum required is 3.8)
Reason given by package:
Interpreter: Cannot run the interpreter /usr/local/google/home/jbcoe/.cache/uv/builds-v0/.tmp3PzyhH/bin/python3
Call Stack (most recent call first):
/usr/share/cmake-3.31/Modules/FindPackageHandleStandardArgs.cmake:603 (_FPHSA_FAILURE_MESSAGE)
/usr/share/cmake-3.31/Modules/FindPython/Support.cmake:3997 (find_package_handle_standard_args)
/usr/share/cmake-3.31/Modules/FindPython.cmake:631 (include)
build/temp.linux-x86_64-cpython-310/_deps/pybind11-src/tools/pybind11NewTools.cmake:54 (find_package)
build/temp.linux-x86_64-cpython-310/_deps/pybind11-src/tools/pybind11Common.cmake:204 (include)
build/temp.linux-x86_64-cpython-310/_deps/pybind11-src/CMakeLists.txt:296 (include)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.