Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(effects-ng): export injection tokens #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Char2sGu
Copy link

@Char2sGu Char2sGu commented Aug 29, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

By provideEffectsManager, we provide an instance of EffectsManager to the token EFFECTS_MANAGER, but the token is not exposed.

When creating utility wrappers upon this library, the EffectsManager instance can be used to register effects, but as the token is not exposed, it can be pretty troublesome to inject the instance.

As an workaround, the user can use the registerEffects function exported from theh @ngneat/effects package, but it makes the code feel un-Angular and it also require the user to check the implementation details.

Issue Number: N/A

What is the new behavior?

The injection tokens are now exported in index so that the user can have access to the provided EffectsManager instance.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@stackblitz
Copy link

stackblitz bot commented Aug 29, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant