feat(effects): export involved ts-action types #65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, we're using some functions from ts-action, but the types involved by these functions are not exposed if the user only installed "@ngneat/effects".
It might be ok for simple use cases, but when the user want to create some utility functions upon this library, it could be a little troublesome, as the user would have to include a whole library "ts-action" in order to have access to a few types to annotate their utility functions.
Besides, if the user choose to install "ts-action" to have access to these types, it can be also a little confusing when it comes to IDE auto-imports, because there could be multiple suggestions for the same function, e.g.
props
.Issue Number: N/A
What is the new behavior?
All the involved types are re-exported from "ts-action".
Does this PR introduce a breaking change?
Other information