Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(effects): export involved ts-action types #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Char2sGu
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Currently, we're using some functions from ts-action, but the types involved by these functions are not exposed if the user only installed "@ngneat/effects".

It might be ok for simple use cases, but when the user want to create some utility functions upon this library, it could be a little troublesome, as the user would have to include a whole library "ts-action" in order to have access to a few types to annotate their utility functions.

Besides, if the user choose to install "ts-action" to have access to these types, it can be also a little confusing when it comes to IDE auto-imports, because there could be multiple suggestions for the same function, e.g. props.

Issue Number: N/A

What is the new behavior?

All the involved types are re-exported from "ts-action".

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@stackblitz
Copy link

stackblitz bot commented Aug 29, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant