Skip to content

Update golangci lint to v2.5.0 #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 9, 2025
Merged

Update golangci lint to v2.5.0 #570

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c21797c
Update dependency golangci/golangci-lint to v2.5.0
renovate[bot] Oct 8, 2025
250cd39
Address linter issue
pdabelf5 Oct 9, 2025
adf5f1d
Return values
pdabelf5 Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
- name: Lint Go
uses: golangci/golangci-lint-action@4afd733a84b1f43292c63897423277bb7f4313a9 # v8.0.0
with:
version: v2.4.0 # renovate: datasource=github-tags depName=golangci/golangci-lint
version: v2.5.0 # renovate: datasource=github-tags depName=golangci/golangci-lint

actionlint:
name: Actionlint
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# renovate: datasource=github-tags depName=golangci/golangci-lint
GOLANGCI_LINT_VERSION = v2.4.0
GOLANGCI_LINT_VERSION = v2.5.0

test: unit-test test-integration test-integration-no-stream-block clean

Expand Down
2 changes: 1 addition & 1 deletion client/nginx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1002,7 +1002,7 @@
}
}

return
return toAdd, toRemove, toUpdate
}

func (client *NginxClient) getIDOfHTTPServer(ctx context.Context, upstream string, name string) (int, error) {
Expand Down Expand Up @@ -1376,7 +1376,7 @@
}
}

return

Check failure on line 1379 in client/nginx.go

View workflow job for this annotation

GitHub Actions / Go Lint 

File is not properly formatted (gofumpt)
}

// GetStats gets process, slab, connection, request, ssl, zone, stream zone, upstream and stream upstream related stats from the NGINX Plus API.
Expand Down
Loading