Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NFR Test Results for NGF version edge #3079

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

NFR Test Results for NGF version edge #3079

wants to merge 1 commit into from

Conversation

nginx-bot
Copy link
Contributor

@nginx-bot nginx-bot commented Feb 1, 2025 •
edited
Loading

Update with NFR test results for NGF version edge ["oss","plus"]

  • Auto-generated by the NFR tests workflow run 13606456748
  • Tests ran using Docker image tag edge
  • all test(s) ran

@nginx-bot nginx-bot requested a review from a team as a code owner February 1, 2025 19:50
@github-actions github-actions bot added documentation Improvements or additions to documentation tests Pull requests that update tests labels Feb 1, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 1, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.14%. Comparing base (bfd685d) to head (473d1cb).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3079   +/-   ##
=======================================
  Coverage   86.14%   86.14%           
=======================================
  Files         113      113           
  Lines       11648    11648           
  Branches       62       62           
=======================================
  Hits        10034    10034           
  Misses       1553     1553           
  Partials       61       61

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sjberman
sjberman previously approved these changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@sjberman sjberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing more upstream connections issues

@sjberman
Copy link
Collaborator

sjberman commented Feb 3, 2025

pre-commit.ci autofix

bjee19
bjee19 reviewed Feb 3, 2025
View reviewed changes
tests/results/zero-downtime-scale/edge/abrupt-scale-down-affinity-https-oss.png Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's some issue with our zero-downtime-scale test, @sjberman did you see this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I completely missed that file! Yeah that looks bad, we should figure out what's going on here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0% success rate is a problem

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opened an issue to track here #3089

bjee19
bjee19 reviewed Feb 3, 2025
View reviewed changes
tests/results/zero-downtime-scale/edge/edge-oss.md Outdated
Error Set:
Get "https://cafe.example.com/tea": remote error: tls: unrecognized name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most likely related to this issue

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we've encountered it in the past

nginx-gateway-fabric/tests/results/scale/1.2.0/1.2.0.md

Line 163 in c9bd90c

- A few of the requests failed with `remote error: tls: unrecognized name`. This seems to be a transient error. I was able to pass traffic to these server names after the test ended.

@sjberman sjberman dismissed their stale review February 3, 2025 23:37

Unseen issue

@bjee19 bjee19 mentioned this pull request Feb 3, 2025
Closed
@nginx-bot nginx-bot force-pushed the tests/nfr-tests-edge branch from a6a8cef to 472364e Compare February 15, 2025 19:30
@lucacome lucacome removed their assignment Feb 18, 2025
@nginx-bot nginx-bot force-pushed the tests/nfr-tests-edge branch from 838358a to 473d1cb Compare March 1, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjberman sjberman sjberman left review comments

@bjee19 bjee19 bjee19 left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation tests Pull requests that update tests
Projects
NGINX Gateway Fabric
Status: 🆕 New
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nginx-bot @sjberman @bjee19 @lucacome