-
Notifications
You must be signed in to change notification settings - Fork 2k
Tiered rate limits with variables #7884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview will be available once build job completes!
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7884 +/- ##
==========================================
+ Coverage 52.82% 52.92% +0.10%
==========================================
Files 90 90
Lines 21671 21732 +61
==========================================
+ Hits 11447 11502 +55
- Misses 9747 9751 +4
- Partials 477 479 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've given edit suggestions for a lot of style errors in the API key README.
All of the feedback applies to the request method README, too.
- Incorrect product name (We never say just 'Ingress Controller')
- Unnecessary nesting
- Erroneous list numbering (Enumeration doesn't work in plain markdown)
- Title Case instead of sentence case
- Numbered headings
Signed-off-by: Haywood Shannon <[email protected]> Signed-off-by: Haywood Shannon <[email protected]>
a3c19f5
to
6165029
Compare
6165029
to
2a1009a
Compare
Proposed changes
Add the ability to add a condition to the rate limit Policy to allow users to rate limit on an NGINX variable. This can allow users to rate limit based on a variable containing a certain value. For example, rate limit all POST requests to 1 r/s, or if an API Key client name matches a specific regex.
Examples
Closes #7868
Checklist
Before creating a PR, run through this checklist and mark each as complete.