Skip to content

docker files and templates: consider changed pid file path from NGINX 1.27.5 #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2025

Conversation

jngrb
Copy link
Contributor

@jngrb jngrb commented Apr 26, 2025

Proposed changes

Fixing issue #302 caused by nginx/pkg-oss#26 and subsequently #301 by modifying the sed replacement such that they match for the old and the new PID file path (/var/run/nginx.pid and /run/nginx.pid shall be changed to /tmp/nginx.pid)

Checklist

Before creating a PR, run through this checklist and mark each as complete:

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have run the update.sh script and ensured all entrypoint/Dockerfile template changes have been applied to the relevant image entrypoint scripts & Dockerfiles
    • I get weird errors about greadlink and gsed that I don't know/have
  • I have tested that the NGINX Docker unprivileged image builds and runs correctly on all supported architectures on an unprivileged environment (check out the README for more details)
    • only tested for Debian x86_64
  • I have updated any relevant documentation (README.md)

Sorry, something went wrong.

… 1.27.5 and later
@jngrb jngrb requested a review from a team as a code owner April 26, 2025 07:31
Copy link

github-actions bot commented Apr 26, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@jngrb
Copy link
Contributor Author

jngrb commented Apr 26, 2025

I have hereby read the F5 CLA and agree to its terms

@alessfg alessfg enabled auto-merge (squash) April 27, 2025 14:40
@alessfg alessfg added the bug Something isn't working label Apr 27, 2025
@alessfg alessfg linked an issue Apr 27, 2025 that may be closed by this pull request
@alessfg
Copy link
Member

alessfg commented Apr 27, 2025

Thanks for the quick PR! I'll have it merged asap and rebuild the images.

@alessfg alessfg disabled auto-merge April 27, 2025 18:32
@alessfg alessfg merged commit 862160b into nginx:main Apr 27, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nginxinc/nginx-unprivileged:stable-alpine errors when starting
2 participants