Skip to content

docker files and templates: consider changed pid file path from NGINX 1.27.5 #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jngrb
Copy link

@jngrb jngrb commented Apr 26, 2025

Proposed changes

Fixing issue #302 caused by nginx/pkg-oss#26 and subsequently #301 by modifying the sed replacement such that they match for the old and the new PID file path (/var/run/nginx.pid and /run/nginx.pid shall be changed to /tmp/nginx.pid)

Checklist

Before creating a PR, run through this checklist and mark each as complete:

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have run the update.sh script and ensured all entrypoint/Dockerfile template changes have been applied to the relevant image entrypoint scripts & Dockerfiles
    • I get weird errors about greadlink and gsed that I don't know/have
  • I have tested that the NGINX Docker unprivileged image builds and runs correctly on all supported architectures on an unprivileged environment (check out the README for more details)
    • only tested for Debian x86_64
  • I have updated any relevant documentation (README.md)

@jngrb jngrb requested a review from a team as a code owner April 26, 2025 07:31
Copy link

github-actions bot commented Apr 26, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@jngrb
Copy link
Author

jngrb commented Apr 26, 2025

I have hereby read the F5 CLA and agree to its terms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant