Skip to content

Conversation

@sean-breen
Copy link
Contributor

@sean-breen sean-breen commented Oct 24, 2025

Proposed changes

Updates some jobs in the release process workflow files and Makefile.packaging.

  • swap upload host from up-ap-tmp
  • Don't upload our GPG public key with our packages
  • Use github id token when uploading packages, avoids having to pass a JWT via workflow dispatch
  • Removes references to main branch, replaced with dev-v2

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@sean-breen sean-breen marked this pull request as ready for review October 24, 2025 15:01
@sean-breen sean-breen requested a review from a team as a code owner October 24, 2025 15:01
uses: azure/login@6b2456866fc08b011acb422a92a4aa20e2c4de32 # v2.1.0
with:
creds: ${{ secrets.AZURE_CREDENTIALS }}
- name: Azure Upload Release Packages
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to upload to azure for agent V2

Copy link
Contributor Author

@sean-breen sean-breen Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will still be uploading to the normal locations, but it will be handled via a different workflow which will download the signed packages from the test repository to upload to Azure + GitHub, much like what we do for v3.x releases

@sean-breen sean-breen merged commit ea504e0 into dev-v2 Oct 28, 2025
38 checks passed
@sean-breen sean-breen deleted the ci-updates branch October 28, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants