feat: container filters environment variable #700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for configuring container filters through the DOCKER_CONTAINER_FILTERS environment variable, which overrides any filters specified via the -container-filter command line options.
- Introduces
DOCKER_CONTAINER_FILTERSenvironment variable for container filter configuration - Updates help text and documentation to describe the new environment variable
- Implements logic to parse comma-separated filters and override command line options
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cmd/docker-gen/main.go | Adds environment variable parsing logic and updates help documentation |
| README.md | Documents the new DOCKER_CONTAINER_FILTERS environment variable |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
buchdag
force-pushed
the
feat/container-filter-env-var
branch
2 times, most recently
from
e05feb8 to
782c9f3
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
buchdag
force-pushed
the
feat/container-filter-env-var
branch
from
782c9f3 to
e11639b
Compare
buchdag
force-pushed
the
feat/container-filter-env-var
branch
from
e11639b to
20e3958
Compare
|
Tested multiple times on my end, behave as expected, I think this can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #623
ping @p12tic @eorea